Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace synchronized blocks with ReentrantLocks #26

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Apr 1, 2024

relates to FasterXML/jackson-jaxrs-providers#184

using ReentrantLocks instead of synchronized block

There is no 2.18 branch so using 2.17 for now

@cowtowncoder cowtowncoder changed the title remove synchronized blocks Replace synchronized blocks with ReentrantLocks Apr 4, 2024
@cowtowncoder cowtowncoder merged commit 4fd047c into FasterXML:2.17 Apr 4, 2024
3 checks passed
@pjfanning pjfanning deleted the remove-synch branch April 4, 2024 12:37
@pjfanning
Copy link
Member Author

@cowtowncoder do you want to leave this on 2.17 branch or move it to the 2.18 branch?

@cowtowncoder
Copy link
Member

cowtowncoder commented Apr 5, 2024

@pjfanning Was thinking about that -- seems useful enough (and safe) for 2.17.
Maybe cherry-pick counterpart in jackson-jaxrs-providers for 2.17.1 backport.

So I don't think I'd want this reverted (is already merged). Sort of regardless of what we do with jax-rs one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants