Make buildifier run on changed files only, not all files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not necessary, since "buildifier" can be configured in .pre-commit-hooks.yaml. Furthermore, it shouldn't be run on all files, just the changed ones.
Make buildifier use 'system' language - it doesn't need to be a script (since buildifier should be run on the changed files, not all files).
|
Thanks a lot for creating this Pre-Commit rule for BUILD files! |
|
Hi @FelixSeptem, any time to review this? Happy to make changes as necessary! |
|
Another reason this is worthwhile is because your |
|
FWIW I put this up at https://github.com/camusenergy/pre-commit-hooks Ideally I'd set up a Docker so that it automatically fetches buildifier, but that's beyond me for the moment. |
|
Thanks @jlebar! |
|
Pinging @FelixSeptem to determine if this is planned on being merged |
|
Submitted a duplicate of my fix in #3 to @jlebar's repo here: jlebar/pre-commit-hooks#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Commit will pass the list of changed files that match the rule's pattern. This means the script isn't needed, and the rule can use the 'system' language.