Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run more maxTimeMS tests #3940

Merged
merged 76 commits into from
Jan 12, 2024
Merged

Run more maxTimeMS tests #3940

merged 76 commits into from
Jan 12, 2024

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jan 5, 2024 •
edited

Description

Closes #2983.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 11, 2024

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jan 11, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jan 11, 2024
@noisersup noisersup added the code/enhancement Some user-visible feature could work better label Jan 11, 2024
@noisersup noisersup added this to the Next milestone Jan 11, 2024
@noisersup noisersup marked this pull request as ready for review January 11, 2024 11:59
@noisersup noisersup requested a review from a team as a code owner January 11, 2024 11:59
@noisersup noisersup enabled auto-merge (squash) January 11, 2024 11:59
@noisersup noisersup requested review from a team and henvic January 11, 2024 12:00
@noisersup noisersup merged commit 1e736b9 into FerretDB:main Jan 12, 2024
27 of 28 checks passed
@noisersup noisersup deleted the propagate-maxtimems-2983-2 branch January 12, 2024 07:22
@AlekSi AlekSi mentioned this pull request Jan 12, 2024
Draft
9 tasks
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/enhancement Some user-visible feature could work better labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@henvic henvic henvic approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.

Propagate maxTimeMS of find and aggregate to getMore
3 participants
@noisersup @AlekSi @henvic