Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise SCRAM / SASL support in addition to PLAIN #4113

Merged
merged 34 commits into from Mar 7, 2024

Merge branch 'main' into feat/sasl-adv

ceadf72
Select commit
Failed to load commit list.
Merged

Advertise SCRAM / SASL support in addition to PLAIN #4113

Merge branch 'main' into feat/sasl-adv
ceadf72
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Mar 6, 2024 in 0s

73.78% (-0.53%) compared to 5a5ca29

View this Pull Request on Codecov

73.78% (-0.53%) compared to 5a5ca29

Details

Codecov Report

Attention: Patch coverage is 76.11940% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 73.78%. Comparing base (5a5ca29) to head (ceadf72).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4113      +/-   ##
==========================================
- Coverage   74.31%   73.78%   -0.53%     
==========================================
  Files         353      353              
  Lines       22738    22789      +51     
==========================================
- Hits        16897    16816      -81     
- Misses       4552     4693     +141     
+ Partials     1289     1280       -9     
Files Coverage Δ
integration/setup/helpers.go 93.93% <ø> (+15.15%) ⬆️
internal/handler/msg_getparameter.go 93.42% <100.00%> (ø)
internal/handler/msg_usersinfo.go 76.72% <100.00%> (ø)
internal/handler/msg_hello.go 75.34% <75.38%> (-15.57%) ⬇️

... and 12 files with indirect coverage changes