Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL backend #4137

Merged
merged 22 commits into from Mar 4, 2024
Merged

Add MySQL backend #4137

merged 22 commits into from Mar 4, 2024

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Mar 1, 2024

Description

Closes #3413

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@adetunjii adetunjii requested review from AlekSi and a team as code owners March 1, 2024 08:58
@adetunjii adetunjii requested a review from chilagrow March 1, 2024 08:58
@adetunjii adetunjii changed the title Add MySQL backend code Add MySQL backend Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 73.98%. Comparing base (1615d26) to head (28c0e5d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4137      +/-   ##
==========================================
- Coverage   74.71%   73.98%   -0.74%     
==========================================
  Files         353      353              
  Lines       22616    22675      +59     
==========================================
- Hits        16897    16775     -122     
- Misses       4431     4630     +199     
+ Partials     1288     1270      -18     
Files Coverage Δ
internal/backends/mysql/insert.go 0.00% <0.00%> (ø)
internal/backends/mysql/collection.go 0.00% <0.00%> (ø)
internal/util/fsql/db.go 80.88% <0.00%> (-3.74%) ⬇️
internal/backends/mysql/backend.go 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.39% <0.00%> (-0.82%) ⬇️
hana-1 ?
integration 67.39% <0.00%> (-0.82%) ⬇️
mongodb-1 4.75% <0.00%> (-0.02%) ⬇️
postgresql-1 48.22% <0.00%> (-0.23%) ⬇️
postgresql-2 48.72% <0.00%> (-0.14%) ⬇️
postgresql-3 49.22% <0.00%> (-0.14%) ⬇️
sqlite-1 47.53% <0.00%> (-0.13%) ⬇️
sqlite-2 47.91% <0.00%> (-0.14%) ⬇️
sqlite-3 48.31% <0.00%> (-0.09%) ⬇️
unit 32.66% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work 🤗

@AlekSi AlekSi added this to the Next milestone Mar 4, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Mar 4, 2024
@AlekSi AlekSi enabled auto-merge (squash) March 4, 2024 13:39
@AlekSi AlekSi merged commit dc757b9 into FerretDB:main Mar 4, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add MySQL backend
3 participants