Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter to check truncate tag in blog posts #4139

Merged
merged 7 commits into from Mar 8, 2024

Conversation

sbshah97
Copy link
Contributor

@sbshah97 sbshah97 commented Mar 2, 2024

  • Added a check for the presence of the truncate string in blog post files
  • Created unit tests for the new truncate string verification

Description

Closes #4048.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

- Added a check for the presence of the truncate string in blog post files
- Created unit tests for the new truncate string verification
@sbshah97 sbshah97 requested a review from AlekSi as a code owner March 2, 2024 16:59
@CLAassistant
Copy link

CLAassistant commented Mar 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.76%. Comparing base (892780a) to head (c791623).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4139      +/-   ##
==========================================
- Coverage   73.78%   73.76%   -0.02%     
==========================================
  Files         353      353              
  Lines       22789    22789              
==========================================
- Hits        16814    16811       -3     
- Misses       4694     4697       +3     
  Partials     1281     1281              

see 2 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.15% <ø> (-0.07%) ⬇️
integration 67.15% <ø> (-0.07%) ⬇️
mongodb-1 4.87% <ø> (ø)
postgresql-1 48.40% <ø> (-0.03%) ⬇️
postgresql-2 47.20% <ø> (+<0.01%) ⬆️
postgresql-3 49.48% <ø> (+<0.01%) ⬆️
sqlite-1 47.58% <ø> (+0.07%) ⬆️
sqlite-2 23.34% <ø> (-23.02%) ⬇️
sqlite-3 48.64% <ø> (+0.08%) ⬆️
unit 32.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I updated PR title to be more specific 🤗

tools/checkdocs/checkdocs.go Outdated Show resolved Hide resolved
tools/checkdocs/checkdocs.go Outdated Show resolved Hide resolved
@chilagrow chilagrow changed the title "Enhancements to Blog Post Verification" Add linter to check truncate tag in blog posts Mar 6, 2024
@chilagrow chilagrow added the code/chore Code maintenance improvements label Mar 6, 2024
@chilagrow chilagrow added this to the Next milestone Mar 6, 2024
added truncate to missing file
@sbshah97 sbshah97 requested a review from ptrfarkas as a code owner March 7, 2024 01:23
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@AlekSi AlekSi enabled auto-merge (squash) March 7, 2024 05:23
@AlekSi AlekSi merged commit e98d536 into FerretDB:main Mar 8, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add linter to check for "truncate"
4 participants