Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MySQL collection stats #4145

Merged
merged 3 commits into from Mar 6, 2024
Merged

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Mar 5, 2024

Description

Closes #3413

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 73.69%. Comparing base (4a67734) to head (2c232ae).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4145      +/-   ##
==========================================
- Coverage   73.96%   73.69%   -0.28%     
==========================================
  Files         353      353              
  Lines       22680    22738      +58     
==========================================
- Hits        16775    16756      -19     
- Misses       4633     4704      +71     
- Partials     1272     1278       +6     
Files Coverage Δ
internal/backends/mysql/collection.go 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.97% <0.00%> (-0.41%) ⬇️
integration 66.97% <0.00%> (-0.41%) ⬇️
mongodb-1 4.74% <0.00%> (-0.02%) ⬇️
postgresql-1 48.04% <0.00%> (-0.23%) ⬇️
postgresql-2 ?
postgresql-3 49.09% <0.00%> (-0.13%) ⬇️
sqlite-1 47.30% <0.00%> (-0.13%) ⬇️
sqlite-2 47.78% <0.00%> (-0.12%) ⬇️
sqlite-3 ?
unit 32.56% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Mar 5, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Mar 5, 2024
@AlekSi AlekSi enabled auto-merge (squash) March 5, 2024 09:20
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@AlekSi AlekSi merged commit b2a4839 into FerretDB:main Mar 6, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add MySQL backend
3 participants