Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create user in envtool for SQLite #4147

Closed
wants to merge 35 commits into from

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Mar 5, 2024

Description

This PR includes changes on #4133.
Doing the same as PostgreSQL.

Closes #1877.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.82%. Comparing base (5a5ca29) to head (5d8ddb5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4147      +/-   ##
==========================================
- Coverage   74.31%   73.82%   -0.50%     
==========================================
  Files         353      353              
  Lines       22738    22739       +1     
==========================================
- Hits        16897    16786     -111     
- Misses       4552     4684     +132     
+ Partials     1289     1269      -20     
Files Coverage Δ
integration/setup/setup.go 81.25% <100.00%> (ø)
internal/handler/commands.go 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.53% <100.00%> (-0.30%) ⬇️
hana-1 ?
integration 67.53% <100.00%> (-0.30%) ⬇️
mongodb-1 4.75% <25.00%> (+<0.01%) ⬆️
postgresql-1 48.72% <100.00%> (+0.53%) ⬆️
postgresql-2 50.07% <100.00%> (+1.48%) ⬆️
postgresql-3 48.05% <100.00%> (-1.04%) ⬇️
sqlite-1 47.66% <75.00%> (+0.32%) ⬆️
sqlite-2 48.99% <75.00%> (+1.20%) ⬆️
sqlite-3 47.43% <75.00%> (-0.75%) ⬇️
unit 32.59% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Create user in envtool for SQLite Create user in envtool for SQLite Mar 6, 2024
@chilagrow chilagrow added the code/chore Code maintenance improvements label Mar 6, 2024
@chilagrow chilagrow added this to the Next milestone Mar 6, 2024
@chilagrow chilagrow marked this pull request as ready for review March 6, 2024 05:39
@chilagrow chilagrow requested review from AlekSi and a team as code owners March 6, 2024 05:39
@chilagrow chilagrow requested review from rumyantseva, a team, henvic and noisersup March 6, 2024 05:39
@chilagrow chilagrow enabled auto-merge (squash) March 6, 2024 05:40
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow added the do not merge PRs that should not be merged label Mar 6, 2024
@chilagrow
Copy link
Contributor Author

Do not merge tag added to let #4133 merged first

@chilagrow chilagrow closed this Mar 7, 2024
auto-merge was automatically disabled March 7, 2024 09:50

Pull request was closed

@AlekSi AlekSi removed this from the Next milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements do not merge PRs that should not be merged
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enforce new authentication
4 participants