Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support localhost exception #4156

Merged
merged 25 commits into from Mar 12, 2024
Merged

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Mar 6, 2024

Description

Closes #4100.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.83%. Comparing base (eb93ab1) to head (2c58bda).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4156      +/-   ##
==========================================
+ Coverage   69.23%   73.83%   +4.60%     
==========================================
  Files         354      354              
  Lines       23013    23014       +1     
==========================================
+ Hits        15933    16993    +1060     
+ Misses       5723     4725     -998     
+ Partials     1357     1296      -61     
Files Coverage Δ
ferretdb/ferretdb.go 86.51% <ø> (ø)
integration/setup/setup.go 81.37% <100.00%> (+0.12%) ⬆️
internal/clientconn/conninfo/conn_info.go 96.36% <100.00%> (-0.13%) ⬇️
internal/handler/commands.go 100.00% <100.00%> (ø)
internal/handler/msg_whatsmyuri.go 100.00% <100.00%> (ø)
internal/clientconn/conn.go 51.35% <33.33%> (+4.07%) ⬆️
internal/handler/authenticate.go 73.52% <50.00%> (+14.10%) ⬆️

... and 73 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.71% <73.68%> (+5.21%) ⬆️
hana-1 ?
integration 66.71% <73.68%> (+5.21%) ⬆️
mongodb-1 4.84% <10.52%> (+0.03%) ⬆️
postgresql-1 46.17% <73.68%> (?)
postgresql-2 49.00% <68.42%> (-0.18%) ⬇️
postgresql-3 48.86% <57.89%> (+2.56%) ⬆️
sqlite-1 45.39% <73.68%> (?)
sqlite-2 48.19% <68.42%> (-0.16%) ⬇️
sqlite-3 48.03% <57.89%> (+2.66%) ⬆️
unit 32.93% <29.41%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Implement localhost exception Support localhost exception Mar 7, 2024
@chilagrow chilagrow added the code/chore Code maintenance improvements label Mar 7, 2024
@chilagrow chilagrow added this to the Next milestone Mar 7, 2024
@chilagrow chilagrow marked this pull request as ready for review March 7, 2024 08:01
@chilagrow chilagrow requested review from AlekSi, ptrfarkas and a team as code owners March 7, 2024 08:01
@chilagrow chilagrow requested review from rumyantseva, a team, henvic and noisersup March 7, 2024 08:01
@chilagrow chilagrow enabled auto-merge (squash) March 7, 2024 08:02
noisersup
noisersup previously approved these changes Mar 11, 2024
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Mar 11, 2024
AlekSi
AlekSi previously approved these changes Mar 11, 2024
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Mar 11, 2024
@AlekSi
Copy link
Member

AlekSi commented Mar 12, 2024

@chilagrow Is it ready for re-review?

@chilagrow
Copy link
Contributor Author

@chilagrow Is it ready for re-review?

Yes please!

@AlekSi
Copy link
Member

AlekSi commented Mar 12, 2024

Then re-request it :)

AlekSi
AlekSi previously approved these changes Mar 12, 2024
integration/commands_authentication_test.go Outdated Show resolved Hide resolved
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chilagrow chilagrow merged commit 75f5a74 into FerretDB:main Mar 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement localhost exception
5 participants