Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PLAIN mechanism authentication incorrectly working #4163

Merged
merged 5 commits into from Mar 11, 2024

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Mar 11, 2024

Description

I found a bug related to enforcing new authentication, see added test.

Closes #1877.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow changed the title Fix PLAIN mechanism user being authenticated Fix PLAIN mechanism authentication incorrectly working Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.80%. Comparing base (e98d536) to head (4748386).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4163      +/-   ##
==========================================
- Coverage   74.74%   73.80%   -0.94%     
==========================================
  Files         353      353              
  Lines       22789    22797       +8     
==========================================
- Hits        17034    16826     -208     
- Misses       4470     4692     +222     
+ Partials     1285     1279       -6     
Files Coverage Δ
internal/backends/mysql/metadata/registry.go 64.13% <100.00%> (-0.95%) ⬇️
internal/backends/postgresql/metadata/registry.go 71.89% <100.00%> (-0.41%) ⬇️
internal/clientconn/conninfo/conn_info.go 96.49% <100.00%> (+0.06%) ⬆️
internal/handler/msg_logout.go 100.00% <100.00%> (ø)
internal/handler/msg_saslstart.go 78.70% <100.00%> (+0.13%) ⬆️
internal/handler/authenticate.go 76.81% <86.66%> (-0.97%) ⬇️

... and 28 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.24% <87.50%> (-1.26%) ⬇️
hana-1 ?
integration 67.24% <87.50%> (-1.33%) ⬇️
mongodb-1 4.88% <0.00%> (-0.01%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 48.48% <75.00%> (-0.04%) ⬇️
postgresql-2 47.30% <62.50%> (+<0.01%) ⬆️
postgresql-3 49.32% <50.00%> (-0.29%) ⬇️
sqlite-1 47.57% <70.83%> (-0.11%) ⬇️
sqlite-2 46.46% <58.33%> (+0.02%) ⬆️
sqlite-3 48.73% <45.83%> (-0.04%) ⬇️
unit 32.48% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Mar 11, 2024
@chilagrow chilagrow added this to the Next milestone Mar 11, 2024
@chilagrow chilagrow marked this pull request as ready for review March 11, 2024 06:17
@chilagrow chilagrow requested a review from a team as a code owner March 11, 2024 06:17
@chilagrow chilagrow enabled auto-merge (squash) March 11, 2024 06:18
henvic
henvic previously approved these changes Mar 11, 2024
internal/handler/msg_logout.go Outdated Show resolved Hide resolved
@chilagrow chilagrow merged commit f460194 into FerretDB:main Mar 11, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enforce new authentication
3 participants