New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PLAIN mechanism authentication incorrectly working #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chilagrow
changed the title
Fix PLAIN mechanism user being authenticated
Fix PLAIN mechanism authentication incorrectly working
Mar 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4163 +/- ##
==========================================
- Coverage 74.74% 73.80% -0.94%
==========================================
Files 353 353
Lines 22789 22797 +8
==========================================
- Hits 17034 16826 -208
- Misses 4470 4692 +222
+ Partials 1285 1279 -6
... and 28 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
requested review from
AlekSi,
rumyantseva,
a team,
henvic and
noisersup
March 11, 2024 06:17
henvic
previously approved these changes
Mar 11, 2024
henvic
approved these changes
Mar 11, 2024
AlekSi
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found a bug related to enforcing new authentication, see added test.
Closes #1877.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.