Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging of deeply nested documents #4167

Merged
merged 7 commits into from Mar 12, 2024
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 12, 2024

Description

Closes #3759.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Mar 12, 2024
@AlekSi AlekSi self-assigned this Mar 12, 2024
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Mar 12, 2024
@AlekSi AlekSi added this to the Next milestone Mar 12, 2024
@AlekSi AlekSi marked this pull request as ready for review March 12, 2024 09:31
@AlekSi AlekSi requested a review from a team as a code owner March 12, 2024 09:31
@AlekSi AlekSi enabled auto-merge (squash) March 12, 2024 09:31
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 78.84615% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 73.82%. Comparing base (4281187) to head (3871210).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4167      +/-   ##
==========================================
- Coverage   74.30%   73.82%   -0.49%     
==========================================
  Files         354      354              
  Lines       23012    23013       +1     
==========================================
- Hits        17100    16989     -111     
- Misses       4600     4727     +127     
+ Partials     1312     1297      -15     
Files Coverage Δ
integration/integration.go 84.44% <ø> (-0.60%) ⬇️
internal/bson2/document.go 62.85% <100.00%> (ø)
internal/bson2/raw_document.go 84.00% <100.00%> (ø)
internal/bson2/array.go 63.15% <0.00%> (ø)
internal/bson2/raw_array.go 30.30% <0.00%> (ø)
internal/bson2/logging.go 90.27% <80.95%> (-2.37%) ⬇️
internal/wire/op_msg.go 69.29% <81.48%> (+6.02%) ⬆️

... and 13 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.74% <50.00%> (-0.66%) ⬇️
hana-1 ?
integration 66.74% <50.00%> (-0.66%) ⬇️
mongodb-1 4.80% <0.00%> (-0.06%) ⬇️
postgresql-1 48.80% <50.00%> (+0.65%) ⬆️
postgresql-2 49.17% <46.15%> (+2.23%) ⬆️
postgresql-3 46.28% <46.15%> (-2.96%) ⬇️
sqlite-1 47.89% <50.00%> (+0.69%) ⬆️
sqlite-2 48.38% <46.15%> (+2.29%) ⬆️
sqlite-3 45.36% <46.15%> (-3.01%) ⬇️
unit 32.92% <75.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested review from a team, henvic and noisersup March 12, 2024 09:51
@AlekSi AlekSi disabled auto-merge March 12, 2024 13:11
@AlekSi AlekSi merged commit a8fc642 into FerretDB:main Mar 12, 2024
29 checks passed
@AlekSi AlekSi deleted the nested-documents branch March 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support lazy BSON decoding
2 participants