Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use fjson #4175

Merged
merged 7 commits into from Mar 13, 2024
Merged

Do not use fjson #4175

merged 7 commits into from Mar 13, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 13, 2024

Description

Closes #4157.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Mar 13, 2024
@AlekSi AlekSi self-assigned this Mar 13, 2024
@AlekSi AlekSi changed the title Fjson diff Do not use fjson Mar 13, 2024
@AlekSi AlekSi added this to the Next milestone Mar 13, 2024
@AlekSi AlekSi added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Mar 13, 2024
@AlekSi AlekSi marked this pull request as ready for review March 13, 2024 06:25
@AlekSi AlekSi requested a review from a team as a code owner March 13, 2024 06:25
@AlekSi AlekSi enabled auto-merge (squash) March 13, 2024 06:25
@AlekSi AlekSi requested review from a team, henvic and noisersup March 13, 2024 06:25
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 73.86%. Comparing base (c89b88e) to head (4952712).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4175      +/-   ##
==========================================
- Coverage   74.49%   73.86%   -0.63%     
==========================================
  Files         354      353       -1     
  Lines       23038    22985      -53     
==========================================
- Hits        17162    16979     -183     
- Misses       4555     4708     +153     
+ Partials     1321     1298      -23     
Files Coverage Δ
internal/bson/bson.go 0.00% <ø> (-43.34%) ⬇️
internal/bson2/array.go 65.45% <ø> (+4.43%) ⬆️
internal/bson2/document.go 61.76% <ø> (-2.13%) ⬇️
internal/bson2/logging.go 90.41% <100.00%> (+0.27%) ⬆️
internal/bson2/raw_array.go 32.25% <ø> (+3.68%) ⬆️
internal/bson2/raw_document.go 83.56% <ø> (+1.74%) ⬆️
internal/wire/op_msg.go 70.08% <100.00%> (ø)
internal/wire/op_query.go 53.40% <100.00%> (ø)
internal/wire/op_reply.go 60.86% <100.00%> (ø)
internal/bson2/bson2.go 83.07% <0.00%> (-1.30%) ⬇️
... and 2 more

... and 13 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.31% <17.24%> (-0.10%) ⬇️
hana-1 ?
integration 67.31% <17.24%> (-0.10%) ⬇️
mongodb-1 4.88% <0.00%> (+0.04%) ⬆️
postgresql-1 46.61% <17.24%> (+0.49%) ⬆️
postgresql-2 49.48% <17.24%> (+0.50%) ⬆️
postgresql-3 49.36% <17.24%> (+0.50%) ⬆️
sqlite-1 45.78% <17.24%> (+0.46%) ⬆️
sqlite-2 48.63% <17.24%> (+0.56%) ⬆️
sqlite-3 48.54% <17.24%> (+0.48%) ⬆️
unit 32.93% <44.82%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi disabled auto-merge March 13, 2024 07:58
@AlekSi AlekSi merged commit 34a6fa5 into FerretDB:main Mar 13, 2024
46 of 48 checks passed
@AlekSi AlekSi deleted the fjson-diff branch March 13, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove fjson
2 participants