Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fjson package #4176

Merged
merged 1 commit into from Mar 13, 2024
Merged

Remove fjson package #4176

merged 1 commit into from Mar 13, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 13, 2024

Description

Closes #4157.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Mar 13, 2024
@AlekSi AlekSi added this to the Next milestone Mar 13, 2024
@AlekSi AlekSi self-assigned this Mar 13, 2024
@AlekSi AlekSi marked this pull request as ready for review March 13, 2024 08:05
@AlekSi AlekSi requested a review from a team as a code owner March 13, 2024 08:05
@AlekSi AlekSi enabled auto-merge (squash) March 13, 2024 08:06
@AlekSi AlekSi requested review from a team, henvic and noisersup March 13, 2024 08:06
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.84%. Comparing base (34a6fa5) to head (9d2e43b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4176      +/-   ##
==========================================
- Coverage   73.85%   73.84%   -0.02%     
==========================================
  Files         353      339      -14     
  Lines       22985    22785     -200     
==========================================
- Hits        16975    16825     -150     
+ Misses       4710     4676      -34     
+ Partials     1300     1284      -16     
Files Coverage Δ
internal/types/types.go 93.54% <ø> (ø)

... and 5 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.29% <ø> (-0.01%) ⬇️
integration 67.29% <ø> (-0.01%) ⬇️
mongodb-1 4.89% <ø> (ø)
postgresql-1 46.62% <ø> (+0.03%) ⬆️
postgresql-2 49.45% <ø> (-0.04%) ⬇️
postgresql-3 49.35% <ø> (+0.01%) ⬆️
sqlite-1 45.78% <ø> (+0.02%) ⬆️
sqlite-2 48.60% <ø> (+0.04%) ⬆️
sqlite-3 48.51% <ø> (ø)
unit 32.55% <ø> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi disabled auto-merge March 13, 2024 08:26
@AlekSi AlekSi merged commit ea9c5bd into FerretDB:main Mar 13, 2024
31 of 32 checks passed
@AlekSi AlekSi deleted the remove-fjson branch March 13, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove fjson
2 participants