Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move old bson package #4177

Merged
merged 5 commits into from Mar 13, 2024
Merged

Move old bson package #4177

merged 5 commits into from Mar 13, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 13, 2024

Description

More clean-ups.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.21%. Comparing base (8483f04) to head (ba12b0d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
- Coverage   74.51%   68.21%   -6.30%     
==========================================
  Files         339      339              
  Lines       22786    22786              
==========================================
- Hits        16978    15544    -1434     
- Misses       4502     5884    +1382     
- Partials     1306     1358      +52     
Files Coverage Δ
internal/bson2/oldbson/array.go 70.45% <ø> (ø)
internal/bson2/oldbson/binary.go 62.06% <ø> (ø)
internal/bson2/oldbson/bool.go 64.00% <ø> (ø)
internal/bson2/oldbson/cstring.go 73.68% <ø> (ø)
internal/bson2/oldbson/datetime.go 68.18% <ø> (ø)
internal/bson2/oldbson/document.go 58.94% <ø> (ø)
internal/bson2/oldbson/double.go 73.68% <ø> (ø)
internal/bson2/oldbson/int32.go 70.58% <ø> (ø)
internal/bson2/oldbson/int64.go 70.58% <ø> (ø)
internal/bson2/oldbson/null.go 0.00% <ø> (ø)
... and 6 more

... and 66 files with indirect coverage changes

Flag Coverage Δ
filter-true 60.94% <ø> (-7.12%) ⬇️
hana-1 ?
integration 60.94% <ø> (-7.12%) ⬇️
mongodb-1 4.89% <ø> (+<0.01%) ⬆️
postgresql-1 46.58% <ø> (-0.03%) ⬇️
postgresql-2 49.45% <ø> (+0.08%) ⬆️
postgresql-3 ?
sqlite-1 ?
sqlite-2 48.61% <ø> (+0.07%) ⬆️
sqlite-3 ?
unit 32.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Remove old bson package Move old bson package Mar 13, 2024
@AlekSi AlekSi added this to the Next milestone Mar 13, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Mar 13, 2024
@AlekSi AlekSi marked this pull request as ready for review March 13, 2024 08:38
@AlekSi AlekSi requested a review from a team as a code owner March 13, 2024 08:38
@AlekSi AlekSi enabled auto-merge (squash) March 13, 2024 08:38
@AlekSi AlekSi requested review from a team, henvic and noisersup March 13, 2024 08:38
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 365a3dd into FerretDB:main Mar 13, 2024
26 of 27 checks passed
@AlekSi AlekSi deleted the bson-bson2 branch March 13, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants