Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf dependency to make CI happy #4187

Merged
merged 2 commits into from Mar 14, 2024
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 14, 2024

Description

That functionality is not actually being used, but some of our tools are not smart enough about that.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the deps PRs that update dependencies label Mar 14, 2024
@AlekSi AlekSi added this to the Next milestone Mar 14, 2024
@AlekSi AlekSi self-assigned this Mar 14, 2024
@AlekSi AlekSi marked this pull request as ready for review March 14, 2024 07:19
@AlekSi AlekSi enabled auto-merge (squash) March 14, 2024 07:19
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.72%. Comparing base (346fe7a) to head (57d1db1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4187      +/-   ##
==========================================
- Coverage   74.90%   73.72%   -1.18%     
==========================================
  Files         339      339              
  Lines       22786    22786              
==========================================
- Hits        17068    16800     -268     
- Misses       4419     4698     +279     
+ Partials     1299     1288      -11     

see 32 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.08% <ø> (-1.65%) ⬇️
hana-1 ?
integration 67.08% <ø> (-1.69%) ⬇️
mongodb-1 4.88% <ø> (ø)
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 46.60% <ø> (-0.07%) ⬇️
postgresql-2 ?
postgresql-3 49.30% <ø> (-0.12%) ⬇️
sqlite-1 45.78% <ø> (-0.05%) ⬇️
sqlite-2 48.61% <ø> (-0.09%) ⬇️
sqlite-3 48.54% <ø> (-0.05%) ⬇️
unit 32.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi disabled auto-merge March 14, 2024 07:59
@AlekSi AlekSi merged commit 58ff7b0 into FerretDB:main Mar 14, 2024
27 of 31 checks passed
@AlekSi AlekSi deleted the protobuf branch March 14, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps PRs that update dependencies
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants