Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make our own low-level driver for testing #4193

Merged
merged 49 commits into from Mar 22, 2024
Merged

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Mar 15, 2024

Description

Closes #4146.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 35.13514% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 73.99%. Comparing base (87e7082) to head (79d4319).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4193      +/-   ##
==========================================
- Coverage   74.60%   73.99%   -0.61%     
==========================================
  Files         339      339              
  Lines       22876    22910      +34     
==========================================
- Hits        17067    16953     -114     
- Misses       4502     4660     +158     
+ Partials     1307     1297      -10     
Files Coverage Δ
internal/driver/driver.go 43.80% <35.13%> (+22.68%) ⬆️

... and 17 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.39% <ø> (-0.78%) ⬇️
hana-1 ?
integration 67.39% <ø> (-0.78%) ⬇️
mongodb-1 5.14% <ø> (+<0.01%) ⬆️
postgresql-1 46.57% <ø> (+0.13%) ⬆️
postgresql-2 49.54% <ø> (-0.10%) ⬇️
postgresql-3 49.84% <ø> (+0.05%) ⬆️
sqlite-1 45.69% <ø> (ø)
sqlite-2 48.74% <ø> (-0.08%) ⬇️
sqlite-3 48.97% <ø> (-0.03%) ⬇️
unit 32.69% <35.13%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member Author

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlekSi some questions to you, thanks!

internal/driver/driver_test.go Outdated Show resolved Hide resolved
internal/driver/driver_test.go Outdated Show resolved Hide resolved
internal/driver/driver.go Show resolved Hide resolved
internal/driver/driver_test.go Outdated Show resolved Hide resolved
internal/driver/driver.go Show resolved Hide resolved
@noisersup noisersup enabled auto-merge (squash) March 22, 2024 00:48
@noisersup noisersup requested review from a team, henvic and chilagrow March 22, 2024 00:48
@noisersup noisersup added the code/chore Code maintenance improvements label Mar 22, 2024
@noisersup noisersup added this to the Next milestone Mar 22, 2024
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, see the linter warnings

internal/driver/driver.go Outdated Show resolved Hide resolved
internal/driver/driver.go Outdated Show resolved Hide resolved
internal/driver/driver.go Outdated Show resolved Hide resolved
internal/driver/driver.go Outdated Show resolved Hide resolved
internal/driver/driver.go Outdated Show resolved Hide resolved
internal/driver/driver_test.go Outdated Show resolved Hide resolved
internal/driver/driver_test.go Outdated Show resolved Hide resolved
internal/driver/driver.go Show resolved Hide resolved
internal/driver/driver_test.go Outdated Show resolved Hide resolved
internal/driver/driver_test.go Outdated Show resolved Hide resolved
internal/driver/driver_test.go Outdated Show resolved Hide resolved
@AlekSi AlekSi requested review from a team March 22, 2024 16:11
@AlekSi AlekSi disabled auto-merge March 22, 2024 16:42
@AlekSi AlekSi merged commit 445c9b3 into FerretDB:main Mar 22, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make our own low-level driver for testing
3 participants