Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkdocs checks issues, separate GitHub code #4258

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

kropidlowsky
Copy link
Contributor

@kropidlowsky kropidlowsky commented Apr 24, 2024

Description

Separated GitHub code for checking statuses of issues and added this functionality to Checkdocs.
Done some spot refactoring to Checkcomments.

Closes #4171.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.17%. Comparing base (fb4f384) to head (29a6461).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4258      +/-   ##
==========================================
- Coverage   75.27%   74.17%   -1.11%     
==========================================
  Files         323      323              
  Lines       22408    22408              
==========================================
- Hits        16868    16621     -247     
- Misses       4314     4576     +262     
+ Partials     1226     1211      -15     

see 31 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.23% <ø> (-1.43%) ⬇️
hana-1 ?
integration 67.23% <ø> (-1.49%) ⬇️
mongodb-1 5.11% <ø> (-0.01%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 43.10% <ø> (-8.81%) ⬇️
postgresql-2 41.70% <ø> (-11.76%) ⬇️
postgresql-3 43.29% <ø> (-10.20%) ⬇️
postgresql-4 40.79% <ø> (-0.03%) ⬇️
postgresql-5 45.83% <ø> (-0.02%) ⬇️
sqlite-1 42.35% <ø> (-8.63%) ⬇️
sqlite-2 40.96% <ø> (-11.66%) ⬇️
sqlite-3 42.66% <ø> (-9.95%) ⬇️
sqlite-4 40.06% <ø> (-0.05%) ⬇️
sqlite-5 44.74% <ø> (-0.08%) ⬇️
unit 31.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi self-assigned this May 1, 2024
@AlekSi AlekSi mentioned this pull request May 6, 2024
9 tasks
Taskfile.yml Outdated Show resolved Hide resolved
tools/checkcomments/checkcomments.go Outdated Show resolved Hide resolved
tools/checkcomments/checkcomments.go Outdated Show resolved Hide resolved
tools/checkcomments/checkcomments.go Outdated Show resolved Hide resolved
tools/checkdocs/checkdocs.go Outdated Show resolved Hide resolved
tools/github/issue.go Outdated Show resolved Hide resolved
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Copy link
Contributor

mergify bot commented May 7, 2024

@kropidlowsky this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label May 7, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

checkdocs should check if linked issues are still open
2 participants