New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkdocs
checks issues, separate GitHub code
#4258
Open
kropidlowsky
wants to merge
22
commits into
FerretDB:main
Choose a base branch
from
kropidlowsky:checkdocs-checks-issues
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4258 +/- ##
==========================================
- Coverage 75.27% 74.17% -1.11%
==========================================
Files 323 323
Lines 22408 22408
==========================================
- Hits 16868 16621 -247
- Misses 4314 4576 +262
+ Partials 1226 1211 -15 see 31 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlekSi
reviewed
May 6, 2024
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@kropidlowsky this pull request has merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separated GitHub code for checking statuses of issues and added this functionality to
Checkdocs
.Done some spot refactoring to
Checkcomments
.Closes #4171.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.