Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test new authentication on CI #771

Closed
wants to merge 15 commits into from
Closed

Test new authentication on CI #771

wants to merge 15 commits into from

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Feb 14, 2024 •
edited

Closes #769.

Tests both new and old authentication.

Fixing FerretDB/FerretDB/issues/4115 would allow us to actually test new authentication as it just fails currently.

@b1ron b1ron self-assigned this Feb 14, 2024
@b1ron b1ron added the code/chore Dance tool code or tests configuration maintenance improvements label Feb 14, 2024
@AlekSi
Copy link
Member

AlekSi commented Feb 19, 2024

@b1ron #769 specifically says "do one separate PR for each item, one by one"

@b1ron b1ron changed the title Enable both old and new authencation on CI Enable both old and new authencation Feb 20, 2024
@b1ron b1ron marked this pull request as ready for review February 20, 2024 11:11
@b1ron b1ron requested a review from a team as a code owner February 20, 2024 11:11
@b1ron b1ron requested a review from AlekSi February 20, 2024 11:11
@b1ron b1ron enabled auto-merge (squash) February 20, 2024 11:11
@b1ron
Copy link
Contributor Author

b1ron commented Feb 20, 2024 •
edited

@AlekSi let me know if I need to revert any changes to follow directions as per your comment.

enable "old" authentication in all existing configurations;

Should this PR modify all configuration files, I now assume so.

AlekSi
AlekSi requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do two first items from #769 first in a separate PR

@AlekSi AlekSi marked this pull request as draft February 20, 2024 11:15
auto-merge was automatically disabled February 20, 2024 11:15

Pull request was converted to draft

@b1ron b1ron mentioned this pull request Feb 20, 2024
Closed
@b1ron b1ron changed the title Enable both old and new authencation Test new authentication on CI Feb 26, 2024
@b1ron b1ron mentioned this pull request Feb 26, 2024
Open
5 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 15, 2024

@b1ron this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Apr 15, 2024
@AlekSi AlekSi self-assigned this Apr 15, 2024
@b1ron b1ron closed this by deleting the head repository May 28, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi requested changes

Assignees

@AlekSi AlekSi

@b1ron b1ron

Labels
code/chore Dance tool code or tests configuration maintenance improvements
Projects
Current Engineering
Status: Open
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve tests for authentication
2 participants
@b1ron @AlekSi