Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /src from .npmignore (for debugging) #761

Merged
merged 1 commit into from
May 8, 2019

Conversation

justingrant
Copy link

@justingrant justingrant commented Mar 16, 2019

Popper publishes source maps to NPM (great!) but it doesn't publish the /src folder that the sourcemaps point to. This makes it harder to debug into & set breakpoints in popper code from Chrome or an IDE like VSCode. This PR updates .npmignore to ensure that the /src folder is also (along with /dist) published to NPM.

This shouldn't change anything about Popper's runtime user-facing behavior and the tests probably operate on the source (not a package downloaded from NPM), so I wasn't sure how to build a test to validate these changes. Let me know if you think that new tests are needed.

Fixes #785.

Popper publishes source maps to NPM (great!) but it doesn't publish the /src folder that the sourcemaps point to. This makes it harder to debug into & set breakpoints in popper code from Chrome or an IDE like VSCode.  This PR updates .npmignore to ensure that the /src folder is also, along with /dist, is published to NPM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harder debugging/troubleshooting because /src is excluded by .npmignore
2 participants