-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nss: write a notice about being asked for db password #100
base: master
Are you sure you want to change the base?
nss: write a notice about being asked for db password #100
Conversation
But most users don't have a master password, so it would be confusing wouldn't it? Can we instead print something like |
Good point. I'll try and do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
58e37de
to
4ba70fe
Compare
This works locally for me, I tried with and without a firefox master password.
|
Is this going to be merged anytime? I've been also hit by this. |
Hello, same here, is it planned to be merged someday ? It would really be helpful to have that hint because right now, the password asked is confusing |
2022 and we still have this issue ongoing. What about "Enter your Firefox primary password (or leave blank if no password is set)"? |
Agreed. This really should be clearer. |
cc @FiloSottile |
Thanks for a great tool. I just ran into the cryptic It would save Firefox users with Master/Primary password enabled much time if this got committed :) |
4ba70fe
to
aa9ec5c
Compare
I've updated the PR, so can you try it out? cc @gitressa cc @FiloSottile |
Thanks for a fast reply and update @adamdecaf! It works well, and the help text is shown:
Note the double "))" at the end. Also, the cursor is shown under the Firefox help sentence, at the red arrow ... it's not a big deal. I guess it probably isn't possible to keep it after |
aa9ec5c
to
92b19b8
Compare
Glad to see it working! I fixed the double |
Yeah, that's what I thought. But that's a detail, getting the Firefox primary password message in mkcert is what really counts. Have a great day! |
Issue: #50