Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nss: write a notice about being asked for db password #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamdecaf
Copy link
Contributor

Issue: #50

@FiloSottile
Copy link
Owner

But most users don't have a master password, so it would be confusing wouldn't it?

Can we instead print something like (hint, this is your Firefox master password) if certutil is taking more than 1s?

@adamdecaf
Copy link
Contributor Author

adamdecaf commented Jan 9, 2019

Good point. I'll try and do that.

Copy link
Owner

@FiloSottile FiloSottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamdecaf adamdecaf force-pushed the notice-for-ff-master-password branch from 58e37de to 4ba70fe Compare February 7, 2019 00:47
@adamdecaf
Copy link
Contributor Author

adamdecaf commented Feb 7, 2019

This works locally for me, I tried with and without a firefox master password.

$ go run . -install 
Using the local CA at "/Users/adam/Library/Application Support/mkcert" ✨
The local CA is now installed in the system trust store! ⚡️
Enter Password or Pin for "NSS Certificate DB":
(hint, this is your Firefox master password))
 
The local CA is now installed in the Firefox trust store (requires browser restart)! 🦊
The local CA is now installed in Java's trust store! ☕️
$ go run . -install 
Using the local CA at "/Users/adam/Library/Application Support/mkcert" ✨
The local CA is now installed in the system trust store! ⚡️
The local CA is now installed in the Firefox trust store (requires browser restart)! 🦊
The local CA is now installed in Java's trust store! ☕️

@lopezator
Copy link

Is this going to be merged anytime? I've been also hit by this.

@algorun77
Copy link

Hello, same here, is it planned to be merged someday ? It would really be helpful to have that hint because right now, the password asked is confusing

truststore_nss.go Outdated Show resolved Hide resolved
@jesusdf
Copy link

jesusdf commented Mar 23, 2022

2022 and we still have this issue ongoing.

What about "Enter your Firefox primary password (or leave blank if no password is set)"?

@nathansmithbz
Copy link

Agreed. This really should be clearer.

@adamdecaf
Copy link
Contributor Author

cc @FiloSottile

@gitressa
Copy link

gitressa commented May 16, 2023

Thanks for a great tool. I just ran into the cryptic Enter Password or Pin for "NSS Certificate DB": message, while installing mkcert ddev/ddev#4914.

It would save Firefox users with Master/Primary password enabled much time if this got committed :)

@adamdecaf
Copy link
Contributor Author

I've updated the PR, so can you try it out? cc @gitressa cc @FiloSottile

@gitressa
Copy link

Thanks for a fast reply and update @adamdecaf! It works well, and the help text is shown:

$ mkcert -install
Created a new local CA 💥
The local CA is now installed in the system trust store! ⚡️
Enter Password or Pin for "NSS Certificate DB":
(hint, this is your Firefox primary password))

The local CA is now installed in the Firefox and/or Chrome/Chromium trust store (requires browser restart)! 🦊

2-firefox-tip-rsult

Note the double "))" at the end. Also, the cursor is shown under the Firefox help sentence, at the red arrow ...

1-firefox-tip

it's not a big deal. I guess it probably isn't possible to keep it after [...] "NSS Certificate DB":?

@adamdecaf adamdecaf force-pushed the notice-for-ff-master-password branch from aa9ec5c to 92b19b8 Compare May 17, 2023 18:38
@adamdecaf
Copy link
Contributor Author

Glad to see it working! I fixed the double )). I don't think we can keep the cursor on the previous line - terminals don't work like that.

@gitressa
Copy link

Yeah, that's what I thought. But that's a detail, getting the Firefox primary password message in mkcert is what really counts. Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants