proposal/modal sass compilation #915
Open
+42
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
thanks @oliverturner! a couple of comments but this looks great
Comment on lines
+126
to
+135
| const devOptions = [ | ||
| { | ||
| loader: require.resolve('css-loader'), | ||
| options: cssLoaderOptions | ||
| }, | ||
| { | ||
| loader: require.resolve('sass-loader'), | ||
| options: sassLoaderOptions | ||
| } | ||
| ] |
There was a problem hiding this comment.
question: if we're not using mini-css-extract-plugin or style-loader, how does the CSS get included by the browser?
There was a problem hiding this comment.
Uff... style-loader should defo be in there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a development mode for Sass compilation that removes some of the optimisations –
mini-css-extract-pluginin particular – not required for local development.It enables the proposal for
next-articlehere: https://github.com/Financial-Times/next-article/issues/4534