remove redundant for attribute on labels

the labels are wrapping their inputs, which means they do not need a `for` attribute
Financial-Times · Jun 14, 2021 · c302f29 · c302f29
1 parent 37052af
commit c302f29
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 17 deletions.
diff --git a/demos/src/dynamic-delayed/dynamic-delayed.mustache b/demos/src/dynamic-delayed/dynamic-delayed.mustache
@@ -1,5 +1,5 @@
 <form data-o-component="o-forms">
-    <label class="o-forms-field" for="my-autocomplete">
+    <label class="o-forms-field">
         <span class="o-forms-title">
             <span class="o-forms-title__main">Select your country</span>
         </span>

diff --git a/demos/src/dynamic/dynamic.mustache b/demos/src/dynamic/dynamic.mustache
@@ -1,5 +1,5 @@
 <form data-o-component="o-forms">
-    <label class="o-forms-field" for="my-autocomplete">
+    <label class="o-forms-field">
         <span class="o-forms-title">
             <span class="o-forms-title__main">Select your country</span>
         </span>

diff --git a/demos/src/static/static.mustache b/demos/src/static/static.mustache
@@ -1,4 +1,4 @@
-<label class="o-forms-field" for="my-autocomplete">
+<label class="o-forms-field">
     <span class="o-forms-title">
         <span class="o-forms-title__main">Select your country</span>
     </span>

diff --git a/test/js/helpers/fixtures.js b/test/js/helpers/fixtures.js
@@ -20,20 +20,20 @@ function insert(html) {
 }
 
 function htmlCode () {
-	const html = `<div>
-	<label class="o-forms-field" for="my-autocomplete">
-    <span class="o-forms-title">
-        <span class="o-forms-title__main">Select your country</span>
-    </span>
-    <span class="o-forms-input o-forms-input--select o-forms-input--text">
-        <div data-o-component="o-autocomplete" class="o-autocomplete" id="my-autocomplete">
-            <select id="my-autocomplete">
-                <option value=""></option>
-                <option>Afghanistan</option>
-            </select>
-        </div>
-    </span>
-</label>
+	const html = `<div id=test>
+	<label class="o-forms-field" >
+		<span class="o-forms-title">
+			<span class="o-forms-title__main">Select your country</span>
+		</span>
+		<span class="o-forms-input o-forms-input--select o-forms-input--text">
+			<div data-o-component="o-autocomplete" class="o-autocomplete" id="my-autocomplete">
+				<select id="my-autocomplete">
+					<option value=""></option>
+					<option>Afghanistan</option>
+				</select>
+			</div>
+		</span>
+	</label>
 	</div>
 	`;
 	insert(html);