Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCi Node.js version to 10.13 #450

Merged
merged 1 commit into from May 14, 2020

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented May 13, 2020

Gatsby has made a breaking change in a minor version so we need to update to avoid the build breaking.

gatsbyjs/gatsby#22400 (comment)

If this is your first x-dash pull request please familiarise yourself with the contribution guide before submitting.

I have ran this Node.js version locally and ran the various npm scripts and they succeed, so I think we may be OK to upgrade without any changes.

Closes #442

Gatsby has made a breaking change in a minor version so we need to update to avoid the build breaking.

gatsbyjs/gatsby#22400 (comment)
@apaleslimghost apaleslimghost temporarily deployed to x-dash-fix-broken-doc-w-f5glgi May 13, 2020 12:28 Inactive
@NickColley NickColley marked this pull request as ready for review May 13, 2020 12:45
@NickColley NickColley requested a review from a team as a code owner May 13, 2020 12:45
Copy link
Contributor

@andygout andygout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Is there anything to stop us advancing directly to v12?

@NickColley
Copy link
Contributor Author

NickColley commented May 13, 2020

@andygout just trying to mitigate risk on a project a) I personally don't understand b) I don't believe our team is going to be actively working on this quarter.

@NickColley NickColley merged commit 3f8fb20 into master May 14, 2020
@NickColley NickColley deleted the fix-broken-doc-website-build branch May 14, 2020 09:23
rowanbeentje pushed a commit that referenced this pull request Nov 24, 2021
…uild

Update CircleCi Node.js version to 10.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants