feat: Add api usage metrics for different periods #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3870 +/- ##
==========================================
+ Coverage 96.28% 96.40% +0.12%
==========================================
Files 1143 1145 +2
Lines 36992 37198 +206
==========================================
+ Hits 35618 35862 +244
+ Misses 1374 1336 -38 ☔ View full report in Codecov by Sentry. |
khvn26
reviewed
May 22, 2024
khvn26
reviewed
May 22, 2024
khvn26
approved these changes
May 22, 2024
There was a problem hiding this comment.
Two nitpicks, one naming request I trust @zachaysan to address, otherwise LGTM.
khvn26
reviewed
May 22, 2024
matthewelwell
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
This provides the ability to get API usage data for different billing periods. The supported new periods are the current billing period (i.e., the first day of the billing period till now), the previous billing period, and a 90-day rolling period to the present.
Part of these changes involved with a refactoring of how code is called to influxdb. The former code incorrectly attributed
date_rangeas if it weredate_startwith an inverse modifier. With the former code any callers that had set adate_stopto anything other thannow()the resultant range would be smaller than the interface contract implied. These issues have been addressed and subsequent calling methods have been updated.There was also an issue that cropped up with Pydantic and Freeze Gun, which has been temporarily solved with the addition of an auto-use function in
conftest.py.How did you test this code?
Tested manually against production influxdb to verify results then also added 3 tests to ensure calling signatures to related influxdb functions.