Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add multivariate values when cloning identities #3894

Merged
merged 4 commits into from May 13, 2024

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Change the clone identities endpoints in Core and Edge APIs to clone also multivariate values for overriden feature states having that configuration.

How did you test this code?

Unit tests updated to consider this case

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:07am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:07am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:07am

Copy link
Contributor

github-actions bot commented May 8, 2024

Uffizzi Preview deployment-51413 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (53e728a) to head (397d9b3).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3894    +/-   ##
========================================
  Coverage   95.87%   95.87%            
========================================
  Files        1133     1134     +1     
  Lines       35873    36035   +162     
========================================
+ Hits        34393    34549   +156     
- Misses       1480     1486     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@novakzaballa novakzaballa added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 92e3e9f May 13, 2024
22 checks passed
@novakzaballa novakzaballa deleted the fix/add-multivariate-values-on-clone-identities branch May 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants