fix: Improve the UI/UX for GitHub integrations #3907
Conversation
…ositoriesComponent
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
novakzaballa
requested review from
a team and
kyle-ssg
and removed request for
a team
|
Uffizzi Preview |
novakzaballa
changed the title
| @@ -37,7 +38,7 @@ const DeleteGithubIntegracion: FC<DeleteGithubIntegracionType> = ({ | |||
| github_integration_id: githubId, | |||
| organisation_id: organisationId, | |||
| }).then(() => { | |||
| onConfirm() | |||
| window.location.reload() | |||
There was a problem hiding this comment.
Im confused, does this work ? It doesnt look like the correct way to open a confirmation modal, there's no message onYes etc
There was a problem hiding this comment.
This closes the modal when you delete the installation.
| <Row className='list-item' key={externalResource?.id}> | ||
| <Flex className='table-column mt-1'> | ||
| <Row className='font-weight-medium'> | ||
| {externalResource?.type === 'GITHUB_ISSUE' |
There was a problem hiding this comment.
This is tied to GitHub unnecessarily and overly complex.
Why not just add the following in Constants
resourceTypes: {
GITHUB_ISSUE: {label:"GitHub Issue", type:"GITHUB", id:1}
}
then
<Row className='font-weight-medium'>
Constants.resourceTypes[externalResource?.type]?.label]
There was a problem hiding this comment.
I added that constant and now I'm using it where it's needed.
| placeholder={'Select Type'} | ||
| onChange={(v: GitHubStatusType) => setExternalResourceType(v.label)} | ||
| options={[ | ||
| { id: 1, type: Constants.githubType.githubIssue }, |
There was a problem hiding this comment.
Following above comment this could be Object.values(Constants.resourceTypes).filter((v)=>v.type==='GITHUB')
| ) | ||
| } | ||
|
|
||
| const PermanentRow: FC<PermanentRowType> = ({ |
There was a problem hiding this comment.
The term PermanentRow is confusing, it's not obvious what this is
novakzaballa
force-pushed
the
fix/improve-the-ui-ux-for-github-integrations
branch
from
5e7e6bc
to
4cbace3
Compare
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
How did you test this code?