Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flags #3923

Merged
merged 6 commits into from May 14, 2024
Merged

chore: remove flags #3923

merged 6 commits into from May 14, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented May 10, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Removes the following flags:

  • audit_log_detail
  • feature_enabled_state_filter
  • flagsmith_import_export
  • force_2fa
  • integrations (Unused)
  • not_operator
  • owners_filter
  • payments_on_blocked_page
  • show_edge_identity_overrides
  • show_role_management

How did you test this code?

  • Checked each feature still exists

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 2:06pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 2:06pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 2:06pm

Copy link
Contributor

github-actions bot commented May 10, 2024

Uffizzi Preview deployment-51568 was deleted.

@kyle-ssg
Copy link
Member Author

@novakzaballa show_role_management was marked as permanent, I cannot think of why. Can you please confirm I haven't missed anything obvious.

@kyle-ssg kyle-ssg changed the title chore: remove to remove flags chore: remove flags May 10, 2024
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@novakzaballa
Copy link
Contributor

@novakzaballa show_role_management was marked as permanent, I cannot think of why. Can you please confirm I haven't missed anything obvious.

I don't know why this flag was marked as permanent, but now it can be removed without problems.

@kyle-ssg kyle-ssg added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit c649d1f May 14, 2024
35 checks passed
@kyle-ssg kyle-ssg deleted the chore/remove-to-remove-flags branch May 14, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants