Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed the error message from custom_auth serializer #3924

Conversation

utkarsh-1905
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Changed the error message of custom_auth serializer from "Invalid Email Address" to "Email already exists. Please log in."

Solves #3886
Please describe.

How did you test this code?

Manually

Please describe.

  1. Run the api and frontend locally
  2. Signup using an email and then logout and try to signup again.
  3. The error message shows "Invalid email address" which is confusing to the user.

Signed-off-by: Utkarsh Tripathi <utripathi2002@gmail.com>
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 3:24pm

Copy link

vercel bot commented May 10, 2024

@utkarsh-1905 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented May 10, 2024

Uffizzi Preview deployment-51581 was deleted.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (132ef77) to head (c3d3b29).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3924   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files        1135     1135           
  Lines       36182    36182           
=======================================
  Hits        34731    34731           
  Misses       1451     1451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dabeeeenster dabeeeenster added this pull request to the merge queue May 14, 2024
Merged via the queue into Flagsmith:main with commit 185bd6a May 14, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants