Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some config envs: CHROME_EXE_PATH PATCHED_DRIVER_PATH PATCHED_DRIVER_IS_PATCHED #992

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

milahu
Copy link

@milahu milahu commented Dec 3, 2023

  • use integer type for CHROME_MAJOR_VERSION to make it work with upstream undetected-chromedriver
  • add some config envs, to make this work in a read-only package store (in my case /nix/store)
    • CHROME_EXE_PATH
    • PATCHED_DRIVER_PATH
    • PATCHED_DRIVER_IS_PATCHED

draft PR, because currently, FlareSolverr is using a bundled version of undetected-chromedriver (why?)
in my FlareSolverr package, im using a patched upstream version of undetected-chromedriver

blocked by upstream PRs:

tested. works for me

used in

@ilike2burnthing
Copy link
Contributor

FlareSolverr is using a bundled version of undetected-chromedriver (why?)

It's not stock - https://github.com/FlareSolverr/FlareSolverr/commits/master/src/undetected_chromedriver

@milahu
Copy link
Author

milahu commented Dec 5, 2023

It's not stock

yeah, i just dont get why

undetected_chromedriver is trivial, it can be implemented in a bash oneliner:

sed -i -E 's/\(function \(\) \{window.cdc_[a-zA-Z0-9]{22}/(function () {return;"undetected chromedriver";/' chromedriver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants