forked from JanusGraph/janusgraph
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This updates JUnit, TestContainers, Lombok, and Mockito together as it wasn't possible to only update TestContainers alone since it also depends on JUnit, see PR JanusGraph#2972. The same applies to Mockito. These changes were necessary to update Mockito to v4: Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Calling `property()` on a mocked `StandardVertex` resulted in a `NullPointer` exception, but we can also simply use a `DetachedProperty` as all accesses to that property on the vertex are also already mocked. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
- Loading branch information
1 parent
c4a0a27
commit 1e7af5d
Showing
4 changed files
with
9 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e7af5d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
org.janusgraph.MgmtOlapJobBenchmark.runRemoveIndex
114.81881747272728
ms/op114.05950851272728
ms/op1.01
org.janusgraph.JanusGraphSpeedBenchmark.basicAddAndDelete
12346.027411089672
ms/op13461.300170678296
ms/op0.92
org.janusgraph.GraphCentricQueryBenchmark.getVertices
1694.9315128382784
ms/op2046.9050105544957
ms/op0.83
org.janusgraph.MgmtOlapJobBenchmark.runReindex
403.8170944949451
ms/op349.0224117504762
ms/op1.16
org.janusgraph.JanusGraphSpeedBenchmark.basicCount
294.0587572698004
ms/op288.6154362374195
ms/op1.02
This comment was automatically generated by workflow using github-action-benchmark.