Skip to content

Commit

Permalink
Upgrade to Puppeteer 11 (#4093)
Browse files Browse the repository at this point in the history
* Upgrade to Puppeteer 11

* unsuccessful attempt to refactor createSecureDraft, add todo for the future

* Refactor pageHasSecureDraft() to use getFrame() instead of opening new tab

* use getFrame() in Thunderbird tests

* workaround sending in the 'secure reply btn, reply draft' test

* Simplify openGmailPage()

* fail faster - add timeout param to waitAndClick()

* wip

* handle 'Node is either not clickable' error

* wait longer for @action-step0 and @action-step1

* wait longer for @input-compatibility-fix-expire-years

* wip

* always delete local draft after sending

* cleanup

* rename mock live test

* log

* fix 'secure reply btn, reply draft' test

* cleanup

* do not rely on sleep timeouts

* typo

* timeout in seconds

* let composeBox: Controllable | undefined
  • Loading branch information
limonte committed Nov 9, 2021
1 parent 48d2ee1 commit 994c4d7
Show file tree
Hide file tree
Showing 7 changed files with 190 additions and 184 deletions.
Expand Up @@ -94,11 +94,10 @@ export class ComposeDraftModule extends ViewModule<ComposeView> {
await Ui.time.wait(() => !this.currentlySavingDraft ? true : undefined);
if (this.view.draftId) {
try {
if (this.isLocalDraftId(this.view.draftId)) {
await this.localDraftRemove();
} else {
if (!this.isLocalDraftId(this.view.draftId)) {
await this.view.emailProvider.draftDelete(this.view.draftId);
}
await this.localDraftRemove();
this.view.draftId = '';
} catch (e) {
if (ApiErr.isAuthErr(e)) {
Expand Down

0 comments on commit 994c4d7

Please sign in to comment.