Add test for offline mode #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomholub
reviewed
Mar 8, 2020
|
I'm ok with it as is, given our options |
|
Meaning, I'd be ok to merge it |
Go ahead 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2622
@tomholub first of all, please give your feedback on the test. I decided to add the Gmail test to simulate the real use-case, but if you think that's not the best way, let me know.
Secondly, if the first part is alright and Gmail test is fine here, I'm struggling to get the
pgp_block.htmframe, for some reason thegetFrame()method can't find it and throwing theError: Frame not found: pgp_block.htmexception.