Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5666 Add initial support for Thunderbird (improved setup flow) #5690

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Apr 27, 2024

This PR adds initial support for the Thunderbird desktop email client and the specific goal is to improve the set up flow accordingly.

close #5666
issue #5667


Tests (delete all except exactly one):

  • Difficult to test - (changes are not readily completed for tests)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner April 27, 2024 06:59
@martgil martgil marked this pull request as draft April 27, 2024 06:59
@tomholub
Copy link
Collaborator

How is this looking so far? This looks like it could close #5665 nearly as is. Then you could work on the followup issues in separate PRs. It's always better to make PRs smaller if possible to make progress easier.

One thing I noticed is that the content_scripts/webmail folder already on master is quite disorganised and not so easy to work on to add Thunderbird (or any other webmail) support. I country try and refactor it a little bit myself, and that could make it easier for you.

@tomholub
Copy link
Collaborator

When #5748 is merged, you can follow #5748 (comment) to close #5665 with this PR, then start working on #5666 in next issue. Let's address these one by one instead of trying to do all at once.

@martgil
Copy link
Collaborator Author

martgil commented May 29, 2024

I understood completely, Tom. I'll be following your advice instead of making them work all at once.

@martgil martgil marked this pull request as ready for review June 3, 2024 10:14
@martgil martgil changed the title #5666 #5667 Add initial support for Thunderbird #5666 Add initial support for Thunderbird (improved setup flow) Jun 3, 2024
@martgil
Copy link
Collaborator Author

martgil commented Jun 3, 2024

Hi @sosnovsky - This one is ready for review. Thank you!

@sosnovsky
Copy link
Collaborator

Hi @martgil, can you please describe (or maybe make screenshots) of functionality which can be tested in this PR?
I installed FlowCrypt extension in Thunderbird, configured it and now can see FlowCrypt button on toolbar.
But when opening Encrypted inbox, it loads just empty page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[thunderbird] Add compose button into Thunderbird UI
3 participants