#5681 Update ossar-analysis.yml #5716
Conversation
|
Hello @sosnovsky, this is now ready for review. It's difficult to tackle a place without a map but I'm glad I have found the right root-cause. You can double-check and ensure that this PR fixes the issue by noticing the time it takes for the OSSAR's push vs pull_request and it both finishes in 2 minutes mark.
Compare to other PR's OSSAR test results:
I believe its also better to limit the push checks to master for consistency. As for example, I do not see any codeQL security checks that runs on a pull request for both pull_request and push events at the time. |
|
Ready for review. thank you! |
This comment was marked as outdated.
This comment was marked as outdated.
|
Hello @sosnovsky I had to remove the "$default-branch" from the previous change as they we're meant to be placeholders only for someone who starts to create the GitHub action over GitHub's workflows configuration page - https://github.com/FlowCrypt/flowcrypt-browser/actions/new. This is now ready for another review. Thanks! |
* Update ossar-analysis.yml * Checkout github.sha on push * Add condition for push event * Fix typo * Make checkout repository failsafe * Update ossar-analysis.yml based on the update template from GitHub * Limit OSSAR push check on master branch * Enforce latest updates * Update OSSAR to run on pull_requests * Use ubuntu-latest * Specify master branch --------- Co-authored-by: martgil <martroblesit@gmail.com>
This PR updates the ossar-analysis.yml file in
.github/workflows/by updating the github action to its most recent version.Reference: https://github.com/FlowCrypt/flowcrypt-browser/new/master?filename=.github%2Fworkflows%2Fossar.yml&workflow_template=code-scanning%2Fossar
close #5681
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):