Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5697 Feat: added promise with limit logic #5725

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented May 21, 2024

This PR added promise with limit logic to prevent 429 errors

close #5697 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review May 21, 2024 12:53
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner May 21, 2024 12:53
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

extension/js/common/api/email-provider/gmail/gmail.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky enabled auto-merge (squash) May 22, 2024 12:15
@sosnovsky sosnovsky merged commit 7562156 into master May 22, 2024
12 checks passed
@sosnovsky sosnovsky deleted the 5697-too-many-requests-429-error-when-executing-guesscontactsfromsentemails branch May 22, 2024 12:51
ioanmo226 added a commit that referenced this pull request May 27, 2024
* feat: added promise with limit logic

* fix: promise all limit

* fix: promise limit

* fix: limit

* fix: pr reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Too Many Requests: 429 Error" when executing guessContactsFromSentEmails
2 participants