fix(update-types): updateTypesOnFileSystem ends before writing the fi…

…le (#1031)
ForestAdmin · Feb 20, 2024 · 8a7386c · 8a7386c
1 parent 69cb088
commit 8a7386c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/packages/agent/src/agent.ts b/packages/agent/src/agent.ts
@@ -118,7 +118,7 @@ export default class Agent<S extends TSchema = TSchema> extends FrameworkMounter
   async updateTypesOnFileSystem(typingsPath: string, typingsMaxDepth: number): Promise<void> {
     const { logger } = this.options;
     await this.customizer.getDataSource(logger);
-    this.customizer.updateTypesOnFileSystem(typingsPath, typingsMaxDepth);
+    await this.customizer.updateTypesOnFileSystem(typingsPath, typingsMaxDepth);
   }
 
   /**

diff --git a/packages/forest-cloud/test/commands/update-typings.test.ts b/packages/forest-cloud/test/commands/update-typings.test.ts
@@ -40,11 +40,6 @@ describe('update-typings command', () => {
       cmd.start('Updating typings'),
       cmd.succeed('Your typings have been updated'),
     ]);
-    // TODO: agent does not have an await ! It's a bug but fixed on main.
-    // remove this sleep when merging on main
-    await new Promise(resolve => {
-      setTimeout(resolve, 500);
-    });
 
     await expect(fs.access(setup.bootstrapPathManager.typings)).resolves.not.toThrow();