Replace lodash.sum with native code (#2831)

FormidableLabs · Mar 13, 2024 · d5ef70b · d5ef70b
1 parent 45c1080
commit d5ef70b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/.changeset/giant-bulldogs-accept.md b/.changeset/giant-bulldogs-accept.md
@@ -0,0 +1,5 @@
+---
+"victory-legend": patch
+---
+
+Replace lodash sum with native code
diff --git a/packages/victory-legend/src/helper-methods.ts b/packages/victory-legend/src/helper-methods.ts
@@ -1,4 +1,4 @@
-import { defaults, groupBy, sum, range } from "lodash";
+import { defaults, groupBy, range } from "lodash";
 import { Helpers, Style, TextSize } from "victory-core";
 import { VictoryLegendProps } from "./victory-legend";
 
@@ -330,3 +330,19 @@ export const getBaseProps = (initialProps, fallbackProps) => {
     return childProps;
   }, initialChildProps);
 };
+
+/**
+ * Computes the sum of the values in `array`.
+ * @param {Array} array The array to iterate over.
+ * @returns {number} Returns the sum.
+ */
+function sum(array: number[]) {
+  if (array && array.length) {
+    let value = 0;
+    for (let i = 0; i < array.length; i++) {
+      value += array[i];
+    }
+    return value;
+  }
+  return 0;
+}