Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing component props from main package #1677

Merged
merged 5 commits into from Sep 8, 2020

Conversation

sarah-vanderlaan
Copy link
Contributor

Closes #1623

@sarah-vanderlaan
Copy link
Contributor Author

@boygirl hi! Travis is failing with the following error:

Chromatic CLI v5.0.0
https://www.chromatic.com/docs/cli
✖ Missing project token
Sign in to https://www.chromatic.com/start and create a new project,
or find your project token on the Manage screen in an existing project.
Set your project token as the CHROMATIC_PROJECT_TOKEN environment variable
or pass the --project-token command line option.
ℹ Read more at https://www.chromatic.com/docs/setup
error Command failed with exit code 254.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Chromatic tests failed. Please investigate

Any idea how I can fix this?

@boygirl
Copy link
Contributor

boygirl commented Sep 4, 2020

@sarah-vanderlaan Thanks for this fix. Unfortunately you wont be able to fix the chromatic error, since it has to do with a authenticating the service we are using for visual testing, and we can't give away those secrets. It should not fail CI for you, though. I dug into the CI error in this PR, and it looks like it is failing on the step nps compile-ts. You should be able to run that command locally from the root directory to see a list of errors. Looks like some duplicate identifiers.

@sarah-vanderlaan
Copy link
Contributor Author

@sarah-vanderlaan Thanks for this fix. Unfortunately you wont be able to fix the chromatic error, since it has to do with a authenticating the service we are using for visual testing, and we can't give away those secrets. It should not fail CI for you, though. I dug into the CI error in this PR, and it looks like it is failing on the step nps compile-ts. You should be able to run that command locally from the root directory to see a list of errors. Looks like some duplicate identifiers.

Thank you @boygirl! I solved the build issues :)

@boygirl
Copy link
Contributor

boygirl commented Sep 8, 2020

Thanks! I'll release a patch today :)

@boygirl boygirl merged commit d8c7efa into FormidableLabs:main Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export component props typescript interfaces from main package
2 participants