Added stacked_icon helper #71

jtrost · 2015-01-31T19:34:50Z

This feature is from issue #59

Usage

<%= stacked_icon(
  icon("camera", "", class: "fa-stack-1x"), # The first icon to stack
  icon("ban", "", class: "fa-stack-2x text-danger"), # The second icon to stack
  class: "fa-lg" # Additional classes for fa-stack
) %>

Output

<span class="fa-stack fa-lg"><i class="fa fa-camera fa-stack-1x"></i><i class="fa fa-ban fa-stack-2x text-danger"></i></span>

houndci-bot · 2015-01-31T19:34:51Z

lib/font_awesome/sass/rails/helpers.rb

+
+        def stacked_icon(icon1, icon2, html_options={})
+          content_class = "fa-stack"
+          content_class << " #{html_options[:class]}" if html_options.key?(:class)


Line is too long. [82/80]

jvanbaarsen · 2015-07-22T12:45:43Z

@supercodepoet Is this something you would be interested in? If so what do you think need to be changed for this to be merged? I can take over this PR if needed.

ignisf · 2015-07-27T13:26:47Z

@supercodepoet, apart from the stylistic issues @houndci found in the PR, is there another reason you believe it should not be merged?

Added stacked_icon helper

4a6f3d6

houndci-bot reviewed Jan 31, 2015
View reviewed changes

jtrost mentioned this pull request Jan 31, 2015

Stacked Icon Helper #59

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added stacked_icon helper #71

Added stacked_icon helper #71

jtrost commented Jan 31, 2015

houndci-bot Jan 31, 2015

jvanbaarsen commented Jul 22, 2015

ignisf commented Jul 27, 2015

Added stacked_icon helper #71

Are you sure you want to change the base?

Added stacked_icon helper #71

Conversation

jtrost commented Jan 31, 2015

houndci-bot Jan 31, 2015

Choose a reason for hiding this comment

jvanbaarsen commented Jul 22, 2015

ignisf commented Jul 27, 2015