Use parse only if not an icon object #327
Conversation
| @@ -33,7 +37,7 @@ if(coreHasFeature(ICON_ALIASES)) { | |||
| const vm = mountFromProps({ icon: ['fas', 'close'] }) | |||
|
|
|||
| expect(vm.$el.tagName).toBe('svg') | |||
| expect(vm.$el.classList.contains('fa-close')).toBeTruthy() | |||
| expect(vm.$el.classList.contains('fa-xmark')).toBeTruthy() | |||
There was a problem hiding this comment.
did you want the fa-xmark icon here?
In v6 xmark is the name of the icon and close is the alias.
If we keep the fa-mark we will need to import it (line 4), and will probably want to change the test name; currently test is 'find a free-solid-svg-icon that is an alias'.
As of right now, the test mentioned on the previous line fails because xmark has NOT been imported.
| @@ -12,7 +18,7 @@ function normalizeIconArgs (icon) { | |||
| return null | |||
| } | |||
|
|
|||
| if (typeof icon === 'object' && icon.prefix && icon.iconName) { | |||
| if (icon && typeof icon === 'object' && icon.prefix && icon.iconName) { | |||
There was a problem hiding this comment.
I see that icon.icon is the only difference here between current line 21 and line 9 change.
Would we ever not have an icon.icon property?
I see that this property is the icon details, unicode, svg, etc. My only thought here is that this covers webfonts in the case of an icon not using an svg ... is this correct, so we want to return the icon even if NOT an svg ?
No description provided.