Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue 3x - Add tests for family #458

Merged
merged 1 commit into from
May 1, 2023
Merged

Vue 3x - Add tests for family #458

merged 1 commit into from
May 1, 2023

Conversation

jasonlundien
Copy link
Member

@jasonlundien jasonlundien commented Apr 27, 2023 •
edited

Add tests for sharp family.

@robmadole --- can you review code for accuracy?

@jasonlundien jasonlundien marked this pull request as draft April 27, 2023 02:31
@jasonlundien jasonlundien marked this pull request as ready for review April 27, 2023 02:38
@jasonlundien jasonlundien changed the title Vue 3 - Add tests for family Vue 3x - Add tests for family Apr 27, 2023
robmadole
robmadole approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@robmadole robmadole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Nice clean-up.

@jasonlundien jasonlundien merged commit 444dbfa into 3.x May 1, 2023
36 checks passed
@jasonlundien jasonlundien deleted the vue3-add-family-tests branch May 1, 2023 21:16
@jasonlundien jasonlundien mentioned this pull request Jul 10, 2023
Merged
jasonlundien added a commit that referenced this pull request Jul 10, 2023
@jasonlundien
add tests for family (#458)
3770062
jasonlundien added a commit that referenced this pull request Nov 1, 2023
@jasonlundien
add tests for family (#458)
34def4c
jasonlundien added a commit that referenced this pull request Nov 1, 2023
@jasonlundien
add tests for family (#458)
d745dd0
jasonlundien added a commit that referenced this pull request Nov 1, 2023
@jasonlundien
Vue 3x - Update for titleId and maskId prop along & prettier config (#…
90cad31 
…455)

* add prettier config 

* prettier fixups

* add tests for family (#458)

* add title id and mask id with test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robmadole robmadole robmadole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasonlundien @robmadole