add type constraints for various sql fragment functions #8688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-cheng
requested review from
oetherington
and removed request for
Will-Howard
oetherington
approved these changes
Jan 30, 2024
| @@ -279,7 +280,7 @@ class ProjectionContext<N extends CollectionNameString = CollectionNameString> { | |||
| private compileJoin({table, type = "inner", on, prefix}: SqlJoinSpec): string { | |||
| const selectors: string[] = []; | |||
| for (const field in on) { | |||
| selectors.push(`"${prefix}"."${field}" = ${on[field]}`); | |||
| selectors.push(`"${prefix}"."${field}" = ${on[(field as keyof typeof on)]}`); | |||
There was a problem hiding this comment.
It's pretty sad that TS can't infer this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some generic type constraints to various functions in the parent branch, so as to make life a bit easier & prevent typos/etc.
The main thing I'm not sure about here is the type of
oninSqlJoinBase:Partial<Record<FieldName<N>, string>>technically allows{ _id: undefined }. (The previousRecord<string, string>did not.)There isn't an easy way that I can find to represent a generic type constraint which allows an arbitrary selection of keys from a union type, where the value of those keys must not be undefined if the key is in the object (but any individual key is not required to be in the object). microsoft/TypeScript#13195 introduced
--strictOptionalPropertiesbut we can't enable that; too much stuff breaks.I think it's worth the trade-off here but 馃し
鈹咺ssue is synchronized with this Asana task by Unito