Lane suggestion rewrite #1572
Draft
Lane suggestion rewrite #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karry
force-pushed
the
lane-suggestion-rewrite
branch
from
718ba99
to
a8489ea
Compare
Karry
force-pushed
the
lane-suggestion-rewrite
branch
from
a8489ea
to
a56ed87
Compare
Karry
force-pushed
the
lane-suggestion-rewrite
branch
from
a56ed87
to
f268fed
Compare
Karry
force-pushed
the
lane-suggestion-rewrite
branch
from
445a0c1
to
64325bf
Compare
Framstag
added
the
feature
Instead of evaluating route angle on junction, it read lanes on the ALL outgoing junction ways and use heuristics what lanes we can use to move forward.
Karry
force-pushed
the
lane-suggestion-rewrite
branch
from
64325bf
to
94aba9a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested route lanes are based on turn geometry now (
DirectionDescription).But based on my experience and extensive report Karry/osmscout-sailfish#326 , it provides misleading results on many junctions. So, it should analyze lanes and angles of all ways connected to the analyzed junction node...