Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fonts issue in printing #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arioth
Copy link

@arioth arioth commented Jan 2, 2019

The PDFJS library adds the fonts in the main document.fonts variable. So we need to passed those fonts to the iframe.

@FranckFreiburger
Copy link
Owner

We must also support browsers that does not support fonts api (see font_loader in PDFJS)

@arioth arioth force-pushed the master branch 2 times, most recently from e4d90f5 to 6394bb6 Compare January 3, 2019 14:04
The PDFJS library adds the fonts in the main document.fonts variable. So we need to passed those fonts to the iframe.
@arioth
Copy link
Author

arioth commented Jan 3, 2019

@FranckFreiburger I push a new fix using a div container instead of the iframe. Mostly because I have an issue with firefox with the Font API in the iframe.

@dkurucz
Copy link

dkurucz commented Jan 10, 2019

+1 on this PR. Tested on a local build of a project I'm working on, and the font issues we were seeing with printing are indeed fixed with this. @FranckFreiburger any thoughts on getting this in with a patch version bump?

@momoirocloverz
Copy link

Finally, it's working.

@tritrancs
Copy link

+1 for this PR. Tested locally and it works like a charm.

@yordivd
Copy link

yordivd commented May 27, 2020

why is this not merged yet? What's the best way for me to install these changes @arioth ?
The vue-pdf package on my app is installed through NPM, should i remove it and manually include the source files?

@viktorbk
Copy link

viktorbk commented Jul 9, 2021

It solved my print problem.
Why is this not merged yet?

@DamirAkzhigitov
Copy link

Thanks, it helped me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants