Fix annotation layer misalignment issue #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvago
suggested changes
Jul 28, 2021
| @@ -199,7 +199,7 @@ export default function(PDFJS) { | |||
|
|
|||
| var pageRotate = (pdfPage.rotate === undefined ? 0 : pdfPage.rotate) + (rotate === undefined ? 0 : rotate); | |||
|
|
|||
| var scale = canvasElt.offsetWidth / pdfPage.getViewport({ scale: 1 }).width * (window.devicePixelRatio || 1); | |||
| var scale = canvasElt.offsetWidth / pdfPage.getViewport({ scale: 1 }).width * 1; | |||
There was a problem hiding this comment.
It's probably not going to be merged as the owner doesn't seem to be active on this package.
However, there is no point to multiply by 1, if window.devicePixelRatio is creating problems you might just remove the multiplication.
so instead of * 1 you just write:
var scale = canvasElt.offsetWidth / pdfPage.getViewport({ scale: 1 }).widthThere was a problem hiding this comment.
Thanks for your input. I did try this originally and it didn't always fix the issue in some edge cases. 1 is the second condition, it multiplies by window.devicePixelRatio if the relevant condition is met.
|
@FranckFreiburger would be really great if this issue would be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set ratio to 1. Any other value causes unexpected alignment issues of the annotation layer, specifically some instances in windows 10 google chrome. Tested on multiple devices, this fix has no issues.