Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Revert IncludeDeclaration hashCode overload #1200

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Draft: Revert IncludeDeclaration hashCode overload #1200

wants to merge 1 commit into from

Conversation

peckto
Copy link
Collaborator

@peckto peckto commented Jun 12, 2023

This PR reverts the changes introduced during conversion to kotlin.
The hashCode is not stable and results in uncontrolled recursion.

@peckto peckto force-pushed the fix-IncludeDeclaration-hashCode branch from e6ecd86 to c180437 Compare June 12, 2023 08:10
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@peckto peckto changed the title Revert IncludeDeclaration hashCode overload Draft: Revert IncludeDeclaration hashCode overload Jun 12, 2023
@peckto
Copy link
Collaborator Author

peckto commented Jun 12, 2023

Needs more investigation

@konradweiss konradweiss marked this pull request as draft August 14, 2023 12:53
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@peckto peckto force-pushed the fix-IncludeDeclaration-hashCode branch from c180437 to c6d34dd Compare February 1, 2024 07:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradweiss konradweiss Awaiting requested review from konradweiss konradweiss is a code owner

@oxisto oxisto Awaiting requested review from oxisto oxisto is a code owner

@KuechA KuechA Awaiting requested review from KuechA KuechA will be requested when the pull request is marked ready for review KuechA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peckto @CLAassistant