Add generic parameters for LanguageFrontend
#1236
Merged
+491
−569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
generic-language-frontend
branch
from
34d3971 to
5ec2218
Compare
oxisto
requested review from
KuechA,
maximiliankaul and
konradweiss
as code owners
oxisto
force-pushed
the
generic-language-frontend
branch
4 times, most recently
from
612d292 to
615689b
Compare
KuechA
reviewed
Jul 24, 2023
cpg-language-java/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/java/StatementHandler.kt
Outdated
Show resolved
Hide resolved
cpg-language-java/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/java/StatementHandler.kt
Show resolved
Hide resolved
...ypescript/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/typescript/DeclarationHandler.kt
Outdated
Show resolved
Hide resolved
oxisto
force-pushed
the
generic-language-frontend
branch
2 times, most recently
from
9f26734 to
5d0b69b
Compare
KuechA
approved these changes
Jul 25, 2023
oxisto
force-pushed
the
generic-language-frontend
branch
2 times, most recently
from
7004ce9 to
80e1277
Compare
This PR adds generic parameters representing AST node types and type node types of the original parser.
oxisto
force-pushed
the
generic-language-frontend
branch
from
80e1277 to
6e72424
Compare
|
Kudos, SonarCloud Quality Gate passed! |
oxisto
added a commit
that referenced
this pull request
Jul 27, 2023
This PR adds generic parameters representing AST node types and type node types of the original parser.
oxisto
added a commit
that referenced
this pull request
Jul 27, 2023
This PR adds generic parameters representing AST node types and type node types of the original parser.
oxisto
added a commit
that referenced
this pull request
Jul 27, 2023
This PR adds generic parameters representing AST node types and type node types of the original parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generic parameters representing AST node types and type node types of the original parser. This also allows us to have a much cleaner approach to the methods that return location and code within the frontend.
This breaks the public API because the type parameters are necessary in order to implement a language frontend. This is a preparatory step for #1199