Using IdentityHashSet in EOG pass to remove superfluous EOG nodes
#1275
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes.
oxisto
changed the title
IdentityHashSet in EOG pass to remove superfluous EOG nodes
KuechA
approved these changes
Aug 9, 2023
|
Kudos, SonarCloud Quality Gate passed! |
oxisto
added a commit
that referenced
this pull request
Aug 9, 2023
…1275) * EOG pass speedup There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes. * Add some comments * revert js change --------- Co-authored-by: Alexander Kuechler <alexander.kuechler@aisec.fraunhofer.de>
oxisto
added a commit
that referenced
this pull request
Aug 9, 2023
…1275) * EOG pass speedup There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes. * Add some comments * revert js change --------- Co-authored-by: Alexander Kuechler <alexander.kuechler@aisec.fraunhofer.de>
oxisto
added a commit
that referenced
this pull request
Aug 10, 2023
…1275) * EOG pass speedup There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes. * Add some comments * revert js change --------- Co-authored-by: Alexander Kuechler <alexander.kuechler@aisec.fraunhofer.de>
oxisto
added a commit
that referenced
this pull request
Aug 11, 2023
…1275) * EOG pass speedup There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes. * Add some comments * revert js change --------- Co-authored-by: Alexander Kuechler <alexander.kuechler@aisec.fraunhofer.de>
oxisto
added a commit
that referenced
this pull request
Aug 14, 2023
…1275) * EOG pass speedup There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes. * Add some comments * revert js change --------- Co-authored-by: Alexander Kuechler <alexander.kuechler@aisec.fraunhofer.de>
oxisto
added a commit
that referenced
this pull request
Aug 24, 2023
…1275) * EOG pass speedup There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes. * Add some comments * revert js change --------- Co-authored-by: Alexander Kuechler <alexander.kuechler@aisec.fraunhofer.de>
oxisto
added a commit
that referenced
this pull request
Aug 24, 2023
…1275) * EOG pass speedup There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes. * Add some comments * revert js change --------- Co-authored-by: Alexander Kuechler <alexander.kuechler@aisec.fraunhofer.de>
oxisto
added a commit
that referenced
this pull request
Aug 25, 2023
…1275) * EOG pass speedup There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes. * Add some comments * revert js change --------- Co-authored-by: Alexander Kuechler <alexander.kuechler@aisec.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue that massivly slowed down the EOG pass for programs that a LOT (>500.000) EOG nodes. Now we are using an identity hash set instead of a regular hash set to store the set of unique EOG nodes.