-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements of Go language frontend #1276
Merged
Merged
+3,041
−569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4c4c01
to
fab6e45
Compare
50ab9db
to
bc9866d
Compare
e86261c
to
36e69fc
Compare
446f4a6
to
633348d
Compare
9134847
to
02d5646
Compare
02d5646
to
b267a40
Compare
b11312d
to
348f46e
Compare
konradweiss
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides some Doc and renaming it looks good to me, there are also two comments where I am not sure whether the problem should be solved in this PR or another one in which case I recommend marking the place with a TODO.
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/declarations/FunctionDeclaration.kt
Show resolved
Hide resolved
cpg-language-go/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/golang/BuildConstraints.kt
Show resolved
Hide resolved
cpg-language-go/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/golang/GoUtils.kt
Outdated
Show resolved
Hide resolved
cpg-language-go/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/GoEvaluationOrderGraphPass.kt
Outdated
Show resolved
Hide resolved
…ifier` This PR adds two new language traits, which represents languages that treat functions as first-class citizens, as well as languages that have anonymous identifiers for variables.
* Added parsing of more expressions
67e4395
to
a90a80c
Compare
Kudos, SonarCloud Quality Gate passed! |
konradweiss
approved these changes
Sep 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
iota
expression #1300ast.SendStmt
#1295ast.TypeSwitchStmt
#1296ast.IndexListExpr
#1298iota
expression #1300Fixes