Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More improvements to the Go frontend #1331

Merged
merged 4 commits into from
Mar 7, 2024
Merged

More improvements to the Go frontend #1331

merged 4 commits into from
Mar 7, 2024
+340 −437

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Oct 10, 2023 •
edited
Loading

This includes better handling of (underlying) types as well as better handling of packages.

@oxisto oxisto added the go label Oct 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

83.7% 83.7% Coverage
0.0% 0.0% Duplication

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@oxisto oxisto force-pushed the more-go-fixes branch 2 times, most recently from c9aee16 to 4f51fc2 Compare October 21, 2023 18:35
@oxisto oxisto force-pushed the more-go-fixes branch 2 times, most recently from 096ab06 to 596a31f Compare December 8, 2023 18:56
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@oxisto oxisto changed the title More go fixes More improvements to the Go frontend Jan 10, 2024
@oxisto oxisto marked this pull request as ready for review January 10, 2024 09:52
@oxisto oxisto requested a review from konradweiss as a code owner January 10, 2024 09:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
87.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

oxisto added 2 commits March 7, 2024 09:19
@oxisto
More Go improvements

Verified

This commit was signed with the committer’s verified signature.
boneskull Christopher Hiller
GPG key ID: 517E44D4799F10A6
Verified
Learn about vigilant mode
2c71bfd
@oxisto
Replacement of chained casts
ab47d21
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

konradweiss
konradweiss approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@konradweiss konradweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification

@konradweiss konradweiss merged commit c1ee7c1 into main Mar 7, 2024
4 checks passed
@konradweiss konradweiss deleted the more-go-fixes branch March 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradweiss konradweiss

Assignees
No one assigned
Labels
go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxisto @CLAassistant @konradweiss